Get rid of links to external dependencies in import command #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmpetrov style check is failing - please, read the contributing guide and install the pre-commit hook or editor that adjust the style |
shcheklein
reviewed
Nov 24, 2019
shcheklein
reviewed
Nov 24, 2019
shcheklein
reviewed
Nov 24, 2019
shcheklein
reviewed
Nov 24, 2019
shcheklein
requested changes
Nov 24, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jorgeorpinel
approved these changes
Nov 24, 2019
and fix links per #817 (comment) and #817 (review)
|
Addressed everything. Feel free to also review @dmpetrov. Thanks |
|
Thank you @jorgeorpinel! |
|
@shcheklein I'm not an expert in docs. Are there any blockers left to merge? |
shcheklein
approved these changes
Nov 26, 2019
|
@dmpetrov ha! :) no specific reason, sorry. For some reason I though @jorgeorpinel has merged it already. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External-dependencies is quite advanced concept that is necessary only in rear optimization cases. It is better not to use and reference to external-dependencies if there is no real need.